Remove quit chan from Manager #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jholdstock
force-pushed
the
rm-quit
branch
2 times, most recently
from
92ea395
to
a7c706c
Compare
Make the main loop of the Manager a blocking func which accepts a context. Shutdown the Manager when the context is canceled. This slightly alters the semantics of the code but in a way that has functionally no impact. Previously the Tickers which update the Manager would only be stopped after the HTTP server and creeper had stopped, but now they are stopped immediately when the context is canceled.
davecgh
requested changes
Oct 4, 2023
davecgh
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the main loop of the Manager a blocking func which accepts a context. Shutdown the Manager when the context is canceled.
This slightly alters the semantics of the code but in a way that has functionally no impact. Previously the Tickers which update the Manager would only be stopped after the HTTP server and creeper had stopped, but now they are stopped immediately when the context is canceled.