Update electron to 1.7.10 #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tested fine on deb9, will try to test on macOS today or tomorrow. |
matheusd
force-pushed
the
electron-update
branch
from
f3c25b9 to
4a94f96
Compare
alexlyp
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1051
I tried to update to the 1.8.x release line, but got some undebugable white error screen (electron didn't load the app, didn't throw an exception or gave me anything to indicate where it had errored), so I pulled back to the latest release of the 1.7.x (non-beta) line.
I tested the general functions (seed input, transactions, ticket purchase, simple and advanced mode) on the following platforms:
yarn dev)yarn package)yarn dev)yarn package)Don't have a macOS computer to test, so could use some help there if available.
I had to delete the
node_modulesandapp/node_modulesand executeyarnto rebuild the correct electron/electron-builder packages.Also, on windows I had to manually install the npm package
windows-build-toolsas an admin, but I don't remember having to do that before (see felixrieseberg/windows-build-tools#56 (comment)).I'm getting an exception on shutdown regarding the grpc module. It's a read error, probably due to trying to execute a service after the wallet process has shutdown, or due to one of the streams getting closed (my guess is the block/transaction notification). I only got this during shutdown, so I guess it can be safely ignored for now, but I can try and better pinpoint the origin if needed.