-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cspp recover wallet #2565
Merged
alexlyp
merged 25 commits into
decred:master
from
vctt94:add-cspp-recover-wallet-based-on-amass-branch
Aug 14, 2020
Merged
Add cspp recover wallet #2565
alexlyp
merged 25 commits into
decred:master
from
vctt94:add-cspp-recover-wallet-based-on-amass-branch
Aug 14, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vctt94
force-pushed
the
add-cspp-recover-wallet-based-on-amass-branch
branch
3 times, most recently
from
July 15, 2020 13:04
67a68ea
to
8475ffe
Compare
vctt94
force-pushed
the
add-cspp-recover-wallet-based-on-amass-branch
branch
2 times, most recently
from
August 13, 2020 20:55
f31219a
to
79b42c9
Compare
vctt94
force-pushed
the
add-cspp-recover-wallet-based-on-amass-branch
branch
from
August 14, 2020 19:36
f7671cd
to
0943fbd
Compare
alexlyp
approved these changes
Aug 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK works great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with recoverying privacy wallet.
As @amassarwi is refactoring the startup methods, we decided to make this work on top of his PR.This way it would be easier to test and avoid conflicts, therefore it depends on #2551It also depends on decred/dcrwallet#1773 for the new grpc callGetCoinjoinOutputspByAcctRequest
This PR adds a privacy label to wallets:
And adds a way to recover privacy wallets in case they are recovered.
Closes #2568
It was needed to do some visual changes, as we need to set a mixed and unmixed account. That's how it looks like: