Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cspp recover wallet #2565

Merged

Conversation

vctt94
Copy link
Member

@vctt94 vctt94 commented Jul 6, 2020

This PR deals with recoverying privacy wallet. As @amassarwi is refactoring the startup methods, we decided to make this work on top of his PR.

This way it would be easier to test and avoid conflicts, therefore it depends on #2551

It also depends on decred/dcrwallet#1773 for the new grpc call GetCoinjoinOutputspByAcctRequest

This PR adds a privacy label to wallets:

image

And adds a way to recover privacy wallets in case they are recovered.

Closes #2568

It was needed to do some visual changes, as we need to set a mixed and unmixed account. That's how it looks like:

image

@vctt94 vctt94 force-pushed the add-cspp-recover-wallet-based-on-amass-branch branch 3 times, most recently from 67a68ea to 8475ffe Compare July 15, 2020 13:04
@vctt94 vctt94 force-pushed the add-cspp-recover-wallet-based-on-amass-branch branch 2 times, most recently from f31219a to 79b42c9 Compare August 13, 2020 20:55
@vctt94 vctt94 changed the title [WIP] Add cspp recover wallet Add cspp recover wallet Aug 13, 2020
@vctt94 vctt94 requested a review from ta-lind August 14, 2020 12:08
@vctt94 vctt94 force-pushed the add-cspp-recover-wallet-based-on-amass-branch branch from f7671cd to 0943fbd Compare August 14, 2020 19:36
Copy link
Member

@alexlyp alexlyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK works great!

@alexlyp alexlyp merged commit 6df7a0d into decred:master Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Design: Recover Wallet / Coinjoin accounts
2 participants