Enable tls and improve config. #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Config changed to match dcrctl since that is closer to what the miner does. This removed some totally unneeded options and changed some others. gominer now uses its own directory for config rather than reusing the dcrd one. Add back btc/dcr copyright in config.go (since the whole file came from there). Add sample config file.
|
tACK. When we eventually support mining pools we'll have to improve the url/protocol handling so mining urls work, i.e. stratum+tcp://dcr.coinmine.pl:2222. Totally fine with how it is now though. |
|
Yep, I agree that we will need to change when we support pools (which is what I'm looking at now) but I wanted to get it in the same place as the rest of dcr* first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Config changed to match dcrctl since that is closer to what the miner
does. This removed some totally unneeded options and changed some
others.
gominer now uses its own directory for config rather than reusing the
dcrd one.
Add back btc/dcr copyright in config.go (since the whole file came
from there).
Add sample config file.