-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cms: create batched calls for invoices #1036
Labels
Comments
Would like to work on this. |
ok cool, feel free to ask for any help that you may need. |
@alexlyp what about the same for DCCs? |
Yup makes sense to add those as well. Though different PR obvi |
Sure! of course! After I finish other stuff on GUI, I'd like to jump on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The batched endpoints allowed a much simpler way of fetching proposals as needed in the politeiagui side.
Since we also always display invoices grouped by their status, having a single endpoint creates an inconsistent pagination mechanism and requires different handling in the client.
Having batched calls for invoices will increase the code consistency in the frontend side, speed up the loading and provide a better lazy load solution. That said, two accomplish that in the CMS side we need two add the following calls:
The current invoice statuses we have are:
The main difference from what we currently do for proposals is the addition of the params
timestampMax
andtimestampMin
when asking for the token inventory. The CMS requires the invoices to be filtered by month so to accomplish the desired output here we need to know beforehand what invoices to fetch based on the time filter.The text was updated successfully, but these errors were encountered: