Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cms] Proposal owner invoice approval #1225

Open
alexlyp opened this issue Jun 18, 2020 · 3 comments · May be fixed by #1243
Open

[cms] Proposal owner invoice approval #1225

alexlyp opened this issue Jun 18, 2020 · 3 comments · May be fixed by #1243
Labels

Comments

@alexlyp
Copy link
Member

alexlyp commented Jun 18, 2020

The following is the current thinking of how we'll accomplish the functionality for proposal owners to offer invoice approval when the invoice contains a line item that has a proposal token that they own.

  1. Proposal owners will be able to see invoice details that only pertain to their need for approving: Line items that they control, the contractor rate and the contractor username.
  2. The proposal owner will give an approval or be able to comment on the invoice.
  3. If approved it will send a metadata stream update to the backend that will include a proposal-owner signature of a json payload of the line items they were able to review.
  4. Administrators will not be able to fully approve invoices until proposal owners first approve their line items.
  5. Proposal owners will be notified of needing to review/approve line items on invoice creation.
  6. Proposal owners will be allowed to comment on invoices, but will only be able to see threads that they begin. Administrators will be able to see all comment threads.
  7. Administrators will be given the ability to ping proposal owners that they have reviews waiting on an invoice.
@alexlyp alexlyp linked a pull request Jul 6, 2020 that will close this issue
@xaur
Copy link

xaur commented Oct 11, 2020

Administrators will be able to see all comment threads.

Will invoice authors see all comments too?

@alexlyp
Copy link
Member Author

alexlyp commented Oct 12, 2020

Yes

@xaur
Copy link

xaur commented Mar 22, 2021

Currently proposal owners cannot see unpaid billing against their proposals because of #1329 so I guess that one needs a fix first (separately or as part of #1243).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants