Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cms] Allow commenting on same-domain invoices #1318

Open
xaur opened this issue Oct 15, 2020 · 1 comment
Open

[cms] Allow commenting on same-domain invoices #1318

xaur opened this issue Oct 15, 2020 · 1 comment
Labels

Comments

@xaur
Copy link

xaur commented Oct 15, 2020

Invoices often have issues like malformed data, unclear descriptions or hour amounts that need more clarification or breaking down.

It would be helpful if contractors could comment on same-domain invoices to help each other craft invoices that are easy to audit.

Same visibility rules as in #1225 may be used, i.e.

Proposal owners will be allowed to comment on invoices, but will only be able to see threads that they begin. Administrators will be able to see all comment threads.

Although it is quite restrictive and does not allow reviewing contractors to see each others comments. I would make it more relaxed like:

Same-domain users can see each other's comments and comment on each other's invoices, but cannot see threads started by admins.

@xaur
Copy link
Author

xaur commented Oct 21, 2020

Per chat discussion, allowing all domain peers to comment on an invoice opens the risk of people spamming it with too many questions and frustrating the contractor too much.

The issue of building a productive and scalable review process, and recording all important messages in CMS storage still stands, but this risk must be taken into account.

We will start with discussing issues found in invoices via chat DMs.

@lukebp lukebp added the cms label Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants