Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emails: Use proposal name in email subjects. #1440

Merged
merged 3 commits into from
Jun 28, 2021
Merged

Emails: Use proposal name in email subjects. #1440

merged 3 commits into from
Jun 28, 2021

Conversation

amass01
Copy link
Member

@amass01 amass01 commented Jun 28, 2021

Closes #1434.

lukebp
lukebp requested changes Jun 28, 2021
View reviewed changes
Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal name needs to be in quotes for all of these. Attention to detail.

politeiawww/pi/mail.go Outdated Show resolved Hide resolved
politeiawww/pi/mail.go Outdated Show resolved Hide resolved
politeiawww/pi/mail.go Outdated Show resolved Hide resolved
politeiawww/pi/mail.go Outdated Show resolved Hide resolved
politeiawww/pi/mail.go Outdated Show resolved Hide resolved
@amass01
Copy link
Member Author

amass01 commented Jun 28, 2021

@lukebp oh, missed the template, updated.

lukebp
lukebp requested changes Jun 28, 2021
View reviewed changes
Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is careless. Come on.

https://play.golang.org/p/kkw8MseZMSl

@amass01
Copy link
Member Author

amass01 commented Jun 28, 2021

Opps, fixed.

lukebp
lukebp approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@lukebp lukebp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@lukebp lukebp merged commit 1d04ed4 into decred:master Jun 28, 2021
@amass01 amass01 deleted the emailpropname branch June 29, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebp lukebp lukebp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

www/pi: Use proposal name in email ntfn.
2 participants
@amass01 @lukebp