Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DARC attributes #2033

Merged
merged 10 commits into from
Aug 9, 2019
Merged

DARC attributes #2033

merged 10 commits into from
Aug 9, 2019

Conversation

kc1212
Copy link
Contributor

@kc1212 kc1212 commented Aug 6, 2019

Closes #2012

@kc1212 kc1212 self-assigned this Aug 6, 2019
@kc1212 kc1212 mentioned this pull request Aug 6, 2019
Copy link
Collaborator

@cgrigis cgrigis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but looks good!

byzcoin/contracts.go Outdated Show resolved Hide resolved
byzcoin/contracts.go Outdated Show resolved Hide resolved
byzcoin/transaction.go Show resolved Hide resolved
darc/darc.go Show resolved Hide resolved
darc/expression/expression_test.go Show resolved Hide resolved
byzcoin/contracts.go Outdated Show resolved Hide resolved
byzcoin/contracts.go Outdated Show resolved Hide resolved
@kc1212 kc1212 force-pushed the xattr_callback branch 2 times, most recently from 9938dec to 296ca08 Compare August 7, 2019 11:59
Copy link
Collaborator

@cgrigis cgrigis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gilthoniel Gilthoniel merged commit b02d311 into master Aug 9, 2019
@Gilthoniel Gilthoniel deleted the xattr_callback branch August 9, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify additional data in DARCs
3 participants