Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new darc-rule only in version 3 #2161

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Use new darc-rule only in version 3 #2161

merged 1 commit into from
Dec 9, 2019

Conversation

ineiti
Copy link
Member

@ineiti ineiti commented Dec 8, 2019

There has been a mismatch with the release of the nodes and the spawning of contracts. To keep the chain in a consistent state, the version needs to be updated to version 3, and only then the new darc rule needs to be used.


🙅‍ Friendly checklist:

  • 0. Code comments are added (or updated) when/where needed and explain the WHY of the code.
  • 1. Design choices, user documentation and any additional doc are added (or updated) in READMEs.
  • 2. Any new behaviour is tested and small units of code that can be are unit tested.
  • 3. Code comments are added on tests to explain what they do.
  • 4. Errors are systematically wrapped with a meaningful message using xerrors.Errorf and the %v verb.
  • 5. Hard limit of 80 chars is always respected.
  • 6. Changes are backward compatible.
  • 7. Indentation level does not exceed 5, although 4 is already suspicious.
  • 8. Functions, files, and packages are kept to a manageable size and decomposed into smaller units if needed.
  • 9. There are no magic values.

@ineiti ineiti self-assigned this Dec 8, 2019
There has been a mismatch with the release of the nodes and the spawning of contracts. To keep the chain in a consistent state, the version needs to be updated to version 3, and only then the new darc rule needs to be used.
@ineiti ineiti force-pushed the personhood_version branch from 92f3970 to ad681da Compare December 9, 2019 06:48
@@ -21,6 +21,7 @@ import (
"github.com/qantik/qrgo"
"github.com/urfave/cli"
"go.dedis.ch/cothority/v3"
_ "go.dedis.ch/cothority/v3/bevm"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in the PR ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because BEVM is now part of the byzcoin-conodes, and there are BEVM instructions in the chain. So if BEVM is not included in bcadmin, the command to verify the chain, bcadmin db replay, fails...

@jeffallen jeffallen merged commit fd4161f into master Dec 9, 2019
@ineiti ineiti deleted the personhood_version branch March 24, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants