testing travis-failing test #2383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ineiti
force-pushed
the
test_securedarc
branch
8 times, most recently
from
2b184e1 to
5ae419d
Compare
ineiti
force-pushed
the
test_securedarc
branch
19 times, most recently
from
5181fa5 to
4517444
Compare
ineiti
force-pushed
the
test_securedarc
branch
from
4517444 to
d708e79
Compare
ineiti
force-pushed
the
test_securedarc
branch
from
d708e79 to
cb437ad
Compare
ineiti
force-pushed
the
test_securedarc
branch
from
a8d38b4 to
4366642
Compare
|
Closed in favour of #2384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the previous
serstructure for byzcoin testing toBCTestand adds a nice builder and runner, so that it can also be run from other byzcoin subdirectories.The goal is to have a correct shutdown of the failing tests in #2367 .
It is quite a big PR as it needs a lot of refactoring. There are no changes in the byzcoin-code (except cleanups), only in the tests.
The entrypoint for code review is
byzcoin/bctest.go. It is part of the main-package, which is not ideal, but I'd like it to be used also in other packages. Any idea how to make that happen is welcome.