-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add types in index.tsx #177
Conversation
Pull Request Test Coverage Report for Build 3173676483Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
web/frontend/src/index.tsx
Outdated
getMessages: function (): FlashMessage[] { | ||
return [flashM]; | ||
}, | ||
addMessage: function (msg: '', level: 0): void {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about that though, but I would expect to have the types instead of default values:
addMessage: function (msg: '', level: 0): void {}, | |
addMessage: function (msg: string, level: number): void {}, |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM 🚀
No description provided.