Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add types in index.tsx #177

Merged
merged 4 commits into from
Oct 13, 2022
Merged

Add types in index.tsx #177

merged 4 commits into from
Oct 13, 2022

Conversation

Khadija21102
Copy link
Contributor

No description provided.

@Khadija21102 Khadija21102 requested a review from nkcr October 2, 2022 19:30
@Khadija21102 Khadija21102 self-assigned this Oct 2, 2022
@CLAassistant
Copy link

CLAassistant commented Oct 2, 2022

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Oct 2, 2022

Pull Request Test Coverage Report for Build 3173676483

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 58.5%

Totals Coverage Status
Change from base Build 3143684289: 0.0%
Covered Lines: 2364
Relevant Lines: 4041

💛 - Coveralls

getMessages: function (): FlashMessage[] {
return [flashM];
},
addMessage: function (msg: '', level: 0): void {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure about that though, but I would expect to have the types instead of default values:

Suggested change
addMessage: function (msg: '', level: 0): void {},
addMessage: function (msg: string, level: number): void {},

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@nkcr nkcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 🚀

@nkcr nkcr merged commit 4d22850 into main Oct 13, 2022
@nkcr nkcr deleted the frontend-2022-khadija branch October 13, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants