Change all occurrence of election into form #178

Ghita2002 · 2022-10-02T19:30:39Z

I change election to form. I need to do other changes like changing the image in the home page.

CLAassistant · 2022-10-02T19:30:44Z

All committers have signed the CLA.

coveralls · 2022-10-02T19:33:25Z

Pull Request Test Coverage Report for Build 3169817580

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

205 of 451 (45.45%) changed or added relevant lines in 16 files are covered.
63 unchanged lines in 4 files lost coverage.
Overall coverage remained the same at 58.5%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
services/shuffle/neff/controller/action.go	0	1	0.0%
services/shuffle/neff/controller/mod.go	0	1	0.0%
contracts/evoting/mod.go	15	21	71.43%
services/shuffle/neff/mod.go	29	37	78.38%
contracts/evoting/types/election.go	0	11	0.0%
services/dkg/pedersen/controller/action.go	9	20	45.0%
services/dkg/pedersen/controller/mod.go	2	13	15.38%
contracts/evoting/types/transactions.go	0	17	0.0%
contracts/evoting/evoting.go	108	157	68.79%
contracts/evoting/controller/action.go	0	131	0.0%

Files with Coverage Reduction	New Missed Lines	%
contracts/evoting/types/election.go	1	17.29%
services/shuffle/neff/mod.go	1	84.0%
contracts/evoting/evoting.go	4	69.2%
contracts/evoting/controller/action.go	57	0.0%

Totals
Change from base Build 3143684289:	0.0%
Covered Lines:	2364
Relevant Lines:	4041

💛 - Coveralls

…voting into d-voting_frontend_ghita

nkcr

That's a big chunk, thanks for the update!

I made some comments, mostly about the documentation. Some parts need a bit of rephrasing, otherwise it can be weird.

Also, since this is updating pretty much everything in the code base, you should ensure that nothing got broken along the way. The CI already provides some guarantees but this is not enough. Did you try running the system manually with you changes ? You should ensure that all functionalities are still working, and the web frontend should work both with nomock=on or not (i.e. using the mocks).

nkcr · 2022-10-13T13:28:01Z

README.md


 In D-Voting we use the Neff [[2]] implementation of verifiable shuffling. Once
-an election is closed, an admin can trigger the shuffling steps from the nodes.
+an form is closed, an admin can trigger the shuffling steps from the nodes.


Suggested change

an form is closed, an admin can trigger the shuffling steps from the nodes.

a form is closed, an admin can trigger the shuffling steps from the nodes.

nkcr · 2022-10-13T13:30:03Z

README.md

@@ -107,11 +107,11 @@ be linked to the original voter.
    <img height="50px" src="docs/assets/audit-white.png#gh-dark-mode-only">
 </div>

-**Transparency/Verifiability/Auditability** - The whole election process is
+**Transparency/Verifiability/Auditability** - The whole form process is


a "form process" doesn't make much sense, compared to the previous "election process". We should come with a better naming. In this case we might say the "voting process".
(same in other places)

nkcr · 2022-10-13T13:31:26Z

README.md

@@ -120,12 +120,12 @@ The project has 4 main high-level components:
 **Proxy** - A proxy offers the mean for an external actor such as a website to
 interact with a blockchain node. It is a component of the blockchain node that
 exposes HTTP endpoints for external entities to send commands to the node. The
-proxy is notably used by the web clients to use the election system.
+proxy is notably used by the web clients to use the form system.


here we should either simply say "use the system", or "use the voting system".

nkcr · 2022-10-13T13:32:12Z

README.md


 **Web frontend** - The web frontend is a web app built with React. It offers a
 view for end-users to use the D-Voting system. The app is meant to be used by
 voters and admins. Admins can perform administrative tasks such as creating an
-election, closing it, or revealing the results. Depending on the task, the web
+form, closing it, or revealing the results. Depending on the task, the web


"an election" -> "a form"
(same elsewhere)

nkcr · 2022-10-13T13:32:59Z

README.md

@@ -137,7 +137,7 @@ web-backend has a local database to store configuration data such as
 authorizations. Admins use the web-frontend to perform updates.

 **Blockchain node** - A blockchain node is the wide definition of the program
-that runs on a host and participate in the election logic. The blockchain node
+that runs on a host and participate in the form logic. The blockchain node


"form logic" -> "voting logic".

nkcr · 2022-10-13T13:38:02Z

contracts/evoting/evoting.go

@@ -32,7 +32,7 @@ import (
 const (
 	shufflingProtocolName = "PairShuffle"
 	errGetTransaction     = "failed to get transaction: %v"
-	errGetElection        = "failed to get election: %v"
+	errGetForm        = "failed to get form: %v"


it seems that your IDE is not formatting your go code for you. Please make sure it does by installing the recommended tooling for go code.

nkcr · 2022-10-13T13:41:16Z

docs/ballot_encoding.md

-the election has an attribute called "BallotSize" which is the size 
-that all ballots should have before they're encrypted. Smaller ballots should therefore be 
+In order to maintain complete voter anonymity and untraceability of ballots throughout the
+form process, it is important that all encrypted ballots have the same size. To this aim,


"voting process"

nkcr · 2022-10-13T13:41:49Z

docs/introduction.md

@@ -16,15 +16,15 @@ end-user can interact with the system.

 <p style="text-align:center"><img src="assets/layers.png"/></p>

-## Election flow
+## Form flow


"voting flow"

nkcr · 2022-10-13T13:43:30Z

docs/introduction.md


-<p style="text-align:center"><img src="assets/election flow.png"/></p>
+<p style="text-align:center"><img src="assets/form flow.png"/></p>


You can generate the new sequence diagram but copy/pasting the source bellow there: https://sequencediagram.org/.

Sorry, I'm not sure to understand. Did you mean that I need to past the link in the source line 23 ?

nkcr · 2022-10-13T13:47:32Z

services/dkg/pedersen/mod.go

@@ -166,9 +166,9 @@ type Actor struct {
 	factory     serde.Factory
 	service     ordering.Service
 	context     serde.Context
-	electionFac serde.Factory
+	formFac serde.Factory


same comment about formatting. Your IDE should automatically do gofmt for you, which is the standard code formater for go.

sonarqubecloud · 2022-10-19T21:14:44Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
19 Code Smells

9.8% Coverage
2.0% Duplication

nkcr

Great work 👍

I change election to form. need other changes

c65523d

Ghita2002 added the web frontend label Oct 2, 2022

Ghita2002 requested a review from nkcr October 2, 2022 19:30

Ghita2002 self-assigned this Oct 2, 2022

Meeting 28_sept_2022

8928dde

nkcr marked this pull request as draft October 5, 2022 07:47

Ghita2002 added 3 commits October 7, 2022 10:18

Refactoring all iteration of election to form

bc93254

Merge branch 'd-voting_frontend_ghita' of https://github.com/dedis/d-…

b8cb3f0

…voting into d-voting_frontend_ghita

run prettier on en.json

5f4e788

Ghita2002 marked this pull request as ready for review October 8, 2022 14:33

new commit because not all changes committed

4d485f5

Ghita2002 marked this pull request as draft October 10, 2022 07:08

replacing the home image

15e67d5

Ghita2002 marked this pull request as ready for review October 12, 2022 07:40

nkcr suggested changes Oct 13, 2022

View reviewed changes

Correcting some changing requests

0905955

Ghita2002 requested a review from a team as a code owner October 14, 2022 16:52

Ghita2002 and others added 6 commits October 14, 2022 19:17

formatting some go files

4daf6c1

Adding the new diagram

a107115

Merge branch 'main' into d-voting_frontend_ghita

dfbe868

Correcting some bugs

7f8b0bc

Some refactoring

7518f06

Fixing the bugs

edf5cfe

nkcr approved these changes Oct 24, 2022

View reviewed changes

nkcr merged commit 5be3e40 into main Oct 24, 2022

nkcr deleted the d-voting_frontend_ghita branch October 24, 2022 08:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change all occurrence of election into form #178

Change all occurrence of election into form #178

Ghita2002 commented Oct 2, 2022

CLAassistant commented Oct 2, 2022 •

edited

Loading

coveralls commented Oct 2, 2022 •

edited

Loading

nkcr left a comment

nkcr Oct 13, 2022

nkcr Oct 13, 2022

nkcr Oct 13, 2022

nkcr Oct 13, 2022

nkcr Oct 13, 2022

nkcr Oct 13, 2022

nkcr Oct 13, 2022

nkcr Oct 13, 2022

nkcr Oct 13, 2022

Ghita2002 Oct 14, 2022

nkcr Oct 13, 2022

sonarqubecloud bot commented Oct 19, 2022

nkcr left a comment

	an form is closed, an admin can trigger the shuffling steps from the nodes.
	a form is closed, an admin can trigger the shuffling steps from the nodes.


		<p style="text-align:center"><img src="assets/election flow.png"/></p>
		<p style="text-align:center"><img src="assets/form flow.png"/></p>

Change all occurrence of election into form #178

Change all occurrence of election into form #178

Conversation

Ghita2002 commented Oct 2, 2022

CLAassistant commented Oct 2, 2022 • edited Loading

coveralls commented Oct 2, 2022 • edited Loading

Pull Request Test Coverage Report for Build 3169817580

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

nkcr left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Oct 19, 2022

nkcr left a comment

Choose a reason for hiding this comment

CLAassistant commented Oct 2, 2022 •

edited

Loading

coveralls commented Oct 2, 2022 •

edited

Loading