Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable admin api in prometheus #6

Merged
merged 2 commits into from
May 15, 2024
Merged

Enable admin api in prometheus #6

merged 2 commits into from
May 15, 2024

Conversation

vermapratyush
Copy link

Admin api is needed to take prometheus db snapshot

sameeragarwal
sameeragarwal approved these changes May 15, 2024
View reviewed changes
Copy link

@sameeragarwal sameeragarwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! This would require a submodule update in the main repo

@vermapratyush vermapratyush merged commit 73f4d82 into main May 15, 2024
1 check passed
@vermapratyush vermapratyush deleted the admin-api branch May 15, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sameeragarwal sameeragarwal sameeragarwal approved these changes

@rkothari007 rkothari007 Awaiting requested review from rkothari007

@syscl syscl Awaiting requested review from syscl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vermapratyush @sameeragarwal