Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better sampling #982

Merged
merged 8 commits into from
Apr 20, 2022
Merged

Better sampling #982

merged 8 commits into from
Apr 20, 2022

Conversation

fgregg
Copy link
Contributor

@fgregg fgregg commented Mar 15, 2022

Prompted by #980, this PR will improve the sampling functionality for dedupe.

@coveralls
Copy link

coveralls commented Mar 15, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.8%) to 65.046% when pulling fc81d0a on better_sampling into 1f551d7 on master.

@fgregg
Copy link
Contributor Author

fgregg commented Mar 15, 2022

@zjelveh & @mmcneill, could you try this branch out? the size of the sample is currently hard coded, but if it looks promising, i'll expose a way to adjust the sample size.

@fgregg
Copy link
Contributor Author

fgregg commented Mar 25, 2022

@tonca, I've added record link sampling to this branch. would you be able to try it out?

@fgregg fgregg mentioned this pull request Mar 29, 2022
Closed
@fgregg fgregg merged commit ccd983a into master Apr 20, 2022
@fgregg fgregg mentioned this pull request Apr 27, 2022
Open
@fgregg fgregg deleted the better_sampling branch May 6, 2022 15:58
@tigerang22 tigerang22 mentioned this pull request Aug 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fgregg @coveralls