Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed logging by downgrading slf4j version, upgrade deegree version #124

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fixed logging by downgrading slf4j version, upgrade deegree version #124

merged 1 commit into from
Jul 17, 2024

Conversation

lgoltz
Copy link
Contributor

@lgoltz lgoltz commented Jul 8, 2024

  • Fixed logging
  • Upgrade to deegree 3.5.8

@lgoltz lgoltz added this to the 1.3.0 milestone Jul 8, 2024
@lgoltz lgoltz added bug Something isn't working dependencies Pull requests that update a dependency file labels Jul 8, 2024
@copierrj
Copy link
Member

The TMC decided to merge this PR as it claims to fix the logging. Could you please (for future reference) add some additional information about the issue that is fixed by this PR?

@dstenger
Copy link
Contributor

dstenger commented Jul 17, 2024 •
edited
Loading

@copierrj
No log output was written by deegree because the versions of slf4j had to be adjusted with deegree3.
Just the following was logged before applying this fix:

SLF4J(W): No SLF4J providers were found.
SLF4J(W): Defaulting to no-operation (NOP) logger implementation
...

@dstenger dstenger self-requested a review July 17, 2024 15:49
@copierrj copierrj merged commit 4588f8c into deegree:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanr stephanr stephanr approved these changes

@dstenger dstenger dstenger approved these changes

Assignees
No one assigned
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lgoltz @copierrj @dstenger @stephanr