Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude dependencies that are included in Java 11+ #78

Merged
merged 1 commit into from
May 12, 2023

Conversation

stempler
Copy link
Member

...because when generating Eclipse projects with Maven, in Eclipse there are compile errors like these if the dependencies are included:

The package javax.xml.stream is accessible from more than one module: <unnamed>, java.xml

Additional context:

  • The Maven build itself does not seem to be impacted by the dependencies, just the Eclipse compiler
  • Java version used: 17
  • Generated Eclipse projects with command similar to mvn eclipse:clean eclipse:configure-workspace eclipse:eclipse -Declipse.workspace=<workspace-folder> -Dwtpversion=2.0

@tfr42 tfr42 added the build Build released issues and tasks label Mar 22, 2023
@tfr42
Copy link
Member

tfr42 commented Mar 22, 2023

Thank you for providing this PR. There will be soon a counterpart of this PR for deegree webservices as a preparation for deegree/deegree3#1375.
We plan to release deegree OGC API v1.3 with deegree webservices v3.5 for Java 11/TC 9.x.
The next version 1.4 of deegree OGC API shall then use deegree webservices v3.6 and shall support Java 17/TC 10.x.

@tfr42 tfr42 added the enhancement Improvement of existing feature or function label Mar 30, 2023
@tfr42 tfr42 changed the title build: exclude dependencies that are included in Java 11+ Exclude dependencies that are included in Java 11+ Apr 5, 2023
@tfr42 tfr42 added the dependencies Pull requests that update a dependency file label Apr 5, 2023
@stempler stempler force-pushed the pr/fix-eclipse-build branch from 7b92c01 to 4aeaf1b Compare April 12, 2023 07:31
...because when generating Eclipse projects with Maven, in Eclipse there
are compile errors like these if the dependencies are included:

```
The package javax.xml.stream is accessible from more than one module: <unnamed>, java.xml
```
@stempler stempler force-pushed the pr/fix-eclipse-build branch from 4aeaf1b to 2d02191 Compare May 12, 2023 08:17
@copierrj copierrj merged commit ae8af13 into deegree:main May 12, 2023
@stempler stempler deleted the pr/fix-eclipse-build branch May 12, 2023 10:45
@tfr42 tfr42 added this to the 1.3.0 milestone Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build released issues and tasks dependencies Pull requests that update a dependency file enhancement Improvement of existing feature or function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants