Fixing tests to be independent of system time zone #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stempler
force-pushed
the
pr/test-timezone-dependency
branch
from
28d76f1 to
02b5acd
Compare
...where the test is run.
stempler
force-pushed
the
pr/test-timezone-dependency
branch
from
02b5acd to
ec56e45
Compare
stephanr
approved these changes
May 12, 2023
dstenger
approved these changes
May 12, 2023
tfr42
approved these changes
May 12, 2023
tfr42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...where the test is run.
I set up a GitHub Actions workflow to verify PRs on our fork but ran into an issue with two failing tests.
Taking a closer look it turned out the tests were failing in GitHub Actions because there the timezone is UTC, while on my local system with the German time zone they succeeded.
These changes make the tests independent of the system time zone. What I can't judge is if this problem only existed in the tests or if it has an impact anywhere else in the project.