Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenAPI description also in YAML format #82

Merged
merged 3 commits into from
May 12, 2023

Conversation

stempler
Copy link
Member

@stempler stempler commented Mar 13, 2023

Support serving the OpenAPI description as YAML in addition to the
already supported JSON format.
Also add a configuration option to allow CORS access for all origins. By default this is disabled.

See #76

Please note: Includes changes from PR #81 due to dependency on YAML media type defined there, thus #81 should be merged first.

@stempler
Copy link
Member Author

Updated this PR to also include the changes related to adding the CORS header if enabled. Used the TunableParameter class as suggested.

@tfr42 tfr42 added the enhancement Improvement of existing feature or function label Mar 30, 2023
@stempler stempler force-pushed the pr/openapi-yaml branch from 9dede3e to 1b02b05 Compare May 3, 2023 13:47
@tfr42 tfr42 changed the title feat: serve OpenAPI description also as YAML Add OpenAPI description also in YAML format May 3, 2023
@tfr42 tfr42 added this to the 1.3.0 milestone May 3, 2023
@stempler stempler force-pushed the pr/openapi-yaml branch from 1b02b05 to fc47506 Compare May 3, 2023 15:36
@copierrj
Copy link
Member

copierrj commented May 3, 2023

This PR introduces a new dependency with an incompatible license.

Please update the PR to avoid this dependency. See for reference how to test a TunableParameter:
https://github.com/deegree/deegree3/blob/14422c86d81efd9467f3f76eb7a32224d9188596/deegree-core/deegree-core-coverage/src/test/java/org/deegree/coverage/raster/cache/TestRasterCache.java

stempler and others added 3 commits May 12, 2023 09:40
Support serving the OpenAPI description as YAML in addition to the
already supported JSON format.
Allows configuring if this should be enabled. By default disabled.
@copierrj copierrj merged commit 2616224 into deegree:main May 12, 2023
@stempler stempler deleted the pr/openapi-yaml branch May 12, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing feature or function
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants