Added Dockerfile for building Docker image #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added short instructions on building and usage.
stempler
commented
Mar 30, 2023
| EXPOSE 8080 | ||
|
|
||
| # get dataset list as health check | ||
| HEALTHCHECK \ |
There was a problem hiding this comment.
Not sure if this makes sense as a health check. Otherwise we can replace it with something else or just ditch it.
There was a problem hiding this comment.
The question here is whether the functions provided by Tomcat should be used?
https://tomcat.apache.org/tomcat-9.0-doc/config/valve.html#Health_Check_Valve
tfr42
changed the title
copierrj
reviewed
Apr 5, 2023
| RUN mkdir $DEEGREE_WORKSPACE_ROOT && \ | ||
| (rm -r /usr/local/tomcat/webapps/ROOT || true) | ||
|
|
||
| VOLUME $DEEGREE_WORKSPACE_ROOT |
There was a problem hiding this comment.
$DEEGREE_WORKSPACE_ROOT is evaluated at build time. Therefore this statement is equivalent to VOLUME /workspaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added short instructions on building and usage.
Relates to #83
Currently the Docker image cannot be built with this Dockerfile due to #85