Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version reference in response headers #1102

Closed
axza opened this issue Nov 27, 2020 · 2 comments · Fixed by #1442
Closed

version reference in response headers #1102

axza opened this issue Nov 27, 2020 · 2 comments · Fixed by #1442
Labels
enhancement enhancement or improvement

Comments

@axza
Copy link

axza commented Nov 27, 2020

Hello awesome People!
even if I consider deegree as safe, I would like to have the possibility to suppress the output of the deegree-versions number in the response.
Following is a line reference.

deegree3/deegree-services/deegree-services-commons/src/api/java/org/deegree/services/controller/OGCFrontController.java

Line 306 in 2bdd14a

response.addHeader( "deegree-version", getInstance().version );

Is there anything that speaks against it?
@copierrj
Copy link
Member

Exposing information like this for everybody to see is indeed risky. Usually such information is filtered out by a reverse proxy but perhaps we should consider removing it altogether.

@tfr42 tfr42 added question user question TMC discussion to be discussed by technical management committee members labels Nov 27, 2020
@axza axza closed this as completed Nov 30, 2020
@axza axza reopened this Nov 30, 2020
@tfr42 tfr42 mentioned this issue Dec 17, 2020
Merged
@tfr42
Copy link
Member

tfr42 commented Jan 30, 2022

Please post this as a feature request and if possible a related PR. See our guidelines for working with PR for further information.

@tfr42 tfr42 closed this as completed Jan 30, 2022
@tfr42 tfr42 reopened this Jan 30, 2022
@tfr42 tfr42 added the enhancement enhancement or improvement label Jan 30, 2022
@tfr42 tfr42 removed TMC discussion to be discussed by technical management committee members question user question labels Sep 17, 2022
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 14, 2022
@lgoltz
deegree#1102 (#8654) - added config option ReportDeegreeVersion
ff0b952
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 14, 2022
@lgoltz
deegree#1102 (#8654) - add header with version if config option is set
fe2d03a
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 21, 2022
@lgoltz
deegree#1102 (#8654) - renamed config param
9a61ae8
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 21, 2022
@lgoltz
deegree#1102 (#8654) - describe AddDeegreeVersionToHeader in handbook
bd2e61a
@lgoltz lgoltz mentioned this issue Dec 22, 2022
Merged
latlon-team pushed a commit to lat-lon/deegree3 that referenced this issue Jan 12, 2023
@lgoltz @latlon-team
deegree#1102 (#8654) - added config option ReportDeegreeVersion
20be84d
latlon-team pushed a commit to lat-lon/deegree3 that referenced this issue Jan 12, 2023
@lgoltz @latlon-team
deegree#1102 (#8654) - add header with version if config option is set
830e5a3
latlon-team pushed a commit to lat-lon/deegree3 that referenced this issue Jan 12, 2023
@lgoltz @latlon-team
deegree#1102 (#8654) - renamed config param
be0236a
latlon-team pushed a commit to lat-lon/deegree3 that referenced this issue Jan 12, 2023
@lgoltz @latlon-team
deegree#1102 (#8654) - describe AddDeegreeVersionToHeader in handbook
95134de
@tfr42 tfr42 mentioned this issue Feb 22, 2023
Open
@tfr42 tfr42 removed the in progress label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement enhancement or improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhanced configuration to hide version reference in header lat-lon/deegree3
3 participants
@tfr42 @copierrj @axza