Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Json output format to WMS GetFeatureInfo #1582

Closed
tfr42 opened this issue Oct 13, 2023 · 3 comments · Fixed by #1623 or #1622
Closed

Add support for Json output format to WMS GetFeatureInfo #1582

tfr42 opened this issue Oct 13, 2023 · 3 comments · Fixed by #1623 or #1622
Labels
contributions welcome asking for contribution (time and money sponsor) feature feature funding welcome financial sponsoring wanted (money) WMS deegree Web Map Service

Comments

@tfr42
Copy link
Member

tfr42 commented Oct 13, 2023

deegree WMS GetFeatureInfo operation shall support for Json/GeoJson as output format.

@tfr42 tfr42 added feature feature contributions welcome asking for contribution (time and money sponsor) funding welcome financial sponsoring wanted (money) WMS deegree Web Map Service labels Oct 13, 2023
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 5, 2023
@lgoltz
Copy link
Contributor

lgoltz commented Dec 13, 2023

Any ideas how to enable GeoJSON as output format? GeoJSON does not require a File, XSLTFile and Serializer [1]. Simple proposal:

<FeatureInfoFormats>
  <GetFeatureInfoFormat>
    <GeoJson>true</GeoJson>
    <Format>application/geo+json</Format>
  </GetFeatureInfoFormat>
</FeatureInfoFormats>

[1] https://schemas.deegree.org/services/wms/3.4.0/wms_configuration.xsd

@copierrj
Copy link
Member

Looks great!

A few suggestions:

  • perhaps better to use an empty element because it is only identifying the type of output and setting it to false doesn't seem to make sense.
  • would it be a good idea to be able to configure the output coordinate system?

@stephanr
Copy link
Member

I think it might also make sense to align the configuration with the WFS configuration, as i think deegree supports also outputting geomtries as well, with a vendor-specific parameter.

<attribute name="allowOtherCrsThanWGS84" type="boolean" default="false"/>

lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 18, 2023
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 19, 2023
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 19, 2023
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 19, 2023
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Dec 19, 2023
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Jan 17, 2024
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Jan 24, 2024
@tfr42 tfr42 linked a pull request Jan 25, 2024 that will close this issue
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Feb 7, 2024
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Feb 7, 2024
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Feb 7, 2024
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Feb 7, 2024
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Feb 7, 2024
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Feb 7, 2024
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Feb 7, 2024
lgoltz added a commit to lat-lon/deegree3 that referenced this issue Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome asking for contribution (time and money sponsor) feature feature funding welcome financial sponsoring wanted (money) WMS deegree Web Map Service
Projects
None yet
4 participants