Fixes incorrect result for polygon in left-handed CRS in GeometryValidator #1034
Conversation
…erior in ExteriorRingOrientation and InteriorRingOrientation from validation package
carlospzurita
changed the title
carlospzurita
changed the title
|
We are seeing some errors related to the build process in Travis and Jenkins. We have looking into the logs and have seen some errors that also appeared in other PR. Is there any issue with the continuous integration pipeline? |
|
Travis is currently broken (= fails even when local builds and Jenkins do succeed). This happens often and we are currently unsure what to do about this. Unfortunately there is also a known regression (#1033) in master. We are currently working on that. |
|
Regarding both hasLeftHandedSrs() methods: these two are almost identical. Please create an appropriate helper method in AbstractGeometryValidationEvent in order to avoid too much code duplication. In order to safeguard against future regressions we would like some unittest to be included. |
…teriorRingOrientation and ExteriorRingOrientation classes. Added test for ring orientation using left-handed and right-handed CRS.
|
We added the modifications indicated, both in the AbstractGeometryValidationEvent and in the GeometryValidatorTest. The test for validation is not fully complete, given that in order to maintain the compatibility with other clients, we did not include the left-handed and right-handed in the validation process for geometry orientation. |
|
We see that there are some errors in the CI processes, but we are not sure if this is related to our own code uploaded, the tests provided or other unrelated issue. Can you provide us with some feedback about this? Thank you |
|
Would it be useful for the integration of the pull request if we attend the TMC meeting on 20/03/2020? We can provide any feedback that you need for the solution implemented or the tests included. |
|
We've looked at the latest changes you made and we are happy with the result. |
|
@tfr42 do you know when the next deegree version including this fix will be released? |
tfr42
changed the title
|
Has this fix been released? |
Added fix for #886 methods
hasLeftHandedSrs,isInteriorandisExteriorin InteriorRingOriention and ExteriorRingOrientation respectively. The solution implemented checks the orientation of the axis for the declared Polygon patch to decide the left-handness, and uses this to check if the ring is exterior or interior.