Enable support of transparency for a 4-band GeoTIFF used with GdalLayer #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if we really want to just drop this transparency band stripping code to fix this issue. It was (most likely) added to solve another issue (probably related to handling requests with JPEG as output format). Are you sure we are not breaking something? |
|
From my point of view, with this change we run the risk to help those who want to use a raster with RGB + Alpha but for users who only use the RGB part of RGB + Infrared this would cause problems. Perhaps it would be better to make this configurable or look up what was requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enables support of transparency for a 4-band GeoTIFF used with GdalLayer.
Detailed description of problem: #1065
Closes #1065.