Fix cache handling of raster files #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* provide helper function to create unique cache filenames in the scope of one deeegree instance for raster cacheing * rework IIORasterReader to honor shouldCreateCacheFile() * use helper function of RasterCache and current pyramid level to create a unique dataLocationId * port unique dataLocationId to JAIRasterReader * allow IIOReader to disable cache per level (abc.tif.no-cache-[level]) or per file (abc.tif.no-cache) * prevent cache usage of IIOReader for all files with system property deegree.raster.cache.iioreader=false
stephanr
added
bug
stephanr
changed the title
tfr42
reviewed
Dec 17, 2020
...-core/deegree-core-coverage/src/main/java/org/deegree/coverage/raster/cache/RasterCache.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains both a correction of the cache handling and a method to better control the raster cache for file base raster.
Previously there was the problem that the naming of cache files was derived from the raster data.
This could lead to unwanted errors in two situations.
First it can happen that raster files in different directories have identical names (For example ../data/dop/overview.tif and ../data/infrared/overview.tif).
Secodn the cache files were not distinguished between the different levels, which e.g. a geotiff can contain, and the same cache file was rewritten on every access.