Allow rewriting of request parameters for KVP request #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix NPE on rewrite * prepare layer for dpi testing
…handled correctly + add similarity test to verify that min/max scale with dpi/pixelsize are applied correctly + add similarity tests which check that dpi/pixelsize parameters are handled correctly
+ add missed RemoveMatch * allign vsp handling with documentation
stephanr
added
enhancement
stephanr
changed the title
|
Improving the DPI handling situation in deegree is appreciated. However, the TMC is not ready to accept functionality only to deal with misbehaving clients. |
Since the DPI parameter handling has already been merged with #1086, the rewrite functionality is not continued and the PR will be closed. |
tfr42
removed
needs discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a supplement to #1086 to manipulate single KVP parameters.
The reason for this is, that some desktop clients are sending invlaid parameters or expection uncommon default values.
With this PR parameters of a KVP request can be manipulated to replace faulty parameters or to enable selective defaulting.
For example invalid
DPIparameters can be removed or a default value can be set (asX-DPI).This is targeted to be an easier replacement for rewriting request with a proxy-server like nginx or apache.