Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GML_322_support] add GML 3.2.2 support #1104

Closed
wants to merge 1 commit into from

Conversation

kad-switzc
Copy link

  • Renamed existing version GML_32 to GML_321
  • Added new verison GML_322
  • Added a few tests to make sure the right version is picked.
  • Modified a few methods to check for GML_321 and GML_322 instead of only to check for GML_321 (old GML_32)
  • Left gml:id check intact for GML_321. In GML_322 gml:id is not required.

@tfr42
Copy link
Member

tfr42 commented Dec 11, 2020

@kad-switzc Thanks for contributing to the OSGeo project deegree. Since this is your first code contribution we kindly ask you to read the deegree contribution guidelines and confirm to by sending an email to the deegree users mailing list. Thanks!
And you can also prepare a PR to update the list of contributors with your full name.

@tfr42 tfr42 added the enhancement enhancement or improvement label Dec 11, 2020
@tfr42 tfr42 mentioned this pull request Dec 11, 2020
@tfr42
Copy link
Member

tfr42 commented Dec 11, 2020

@kad-switzc The TMC members like the PR a lot. Unfortunately the integration tests fail at a point where we expect that they should pass. The TMC members like the support of GML 3.2.2 in deegree. We are little bit hesitant to merge it because the PR changes the enumeration of GML versions. We are in favor to keep the existing one for GML 3.2.1 and add a new value for GML 3.2.2 only.

And please check the information available in the wiki https://github.com/deegree/deegree3/wiki/Test-Practices and https://github.com/deegree/deegree3/wiki/Building-deegree3#running-integration-tests.

@tfr42
Copy link
Member

tfr42 commented Dec 11, 2020

@kad-switzc Thanks for confirming to the deegree contribution guidelines.

@copierrj
Copy link
Member

After a lengthy discussion the TMC decided to make gml ids always optional. Although providing a gml id was mandatory in earlier versions of GML the OGC apparently decided to change the GML standard retroactively.

Therefore we decided to merge PR #1092 instead of yours. This change completely removes the gml id check. Some changes you proposed in this PR are however lifted out into PR #1108 in order to add support for 3.2.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants