Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added soapUI test module deegree-integrations-tests #1153

Merged
merged 14 commits into from
Jan 19, 2022

Conversation

lgoltz
Copy link
Contributor

@lgoltz lgoltz commented Jun 28, 2021

This PR adds a new module called "deegree-acceptance-tests" which contains a soapUI (www.soapui.org) maven plugin configuration executing a soapUI test script against a local instance of deegree webservices. The test script verifies the REST-API, and deegree webservices endpoint operations.
This test script is intended to contain tests for deegree specifc extensions and resources. It is complementary to the proposed replacement of the current built-in (but outdated) integration tests (see issue #773).

lgoltz added a commit to lat-lon/deegree3 that referenced this pull request Jun 28, 2021
@tfr42 tfr42 mentioned this pull request Jun 29, 2021
2 tasks
@tfr42 tfr42 added enhancement enhancement or improvement CI and build CI and build system needs rebase PR is not up to date and needs rebase labels Aug 10, 2021
@tfr42 tfr42 removed needs rebase PR is not up to date and needs rebase labels Aug 16, 2021
@tfr42 tfr42 added the under review PR under review by TMC member label Jan 5, 2022
@copierrj
Copy link
Member

copierrj commented Jan 5, 2022

The TMC likes the approach of this PR. However, we would prefer the new module to be named differently. We do not consider these tests to be acceptance. Please change the name of the module into something else such as deegree-soapui-tests.

Because test like these are hard to review for the TMC we would like a list of what is actually tested included. Could you add a small readme document for this purpose to the module?

Copy link
Member

@tfr42 tfr42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to the module name

@tfr42 tfr42 changed the title Added acceptance-tests Added soapUI test module deegree-integrations-tests Jan 19, 2022
@copierrj copierrj merged commit 25b64ed into deegree:master Jan 19, 2022
@tfr42 tfr42 removed the under review PR under review by TMC member label Jan 19, 2022
@tfr42 tfr42 added this to the 3.4.24 milestone Feb 3, 2022
@lgoltz lgoltz deleted the addAcceptanceTests-Prep857 branch December 8, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI and build CI and build system enhancement enhancement or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants