Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extension to the oracle dialect that works analog to the FeatureInspector #1288

Conversation

stephanr
Copy link
Member

This Pull Request contains a new interface org.deegree.sqldialect.oracle.sdo.SDOInspector that can be used to interfere before a geometry is written to or after the geometry has been read from the database.
With this org.deegree.sqldialect.oracle.sdo.SDOInspector, which works similar as org.deegree.feature.persistence.FeatureInspector, it is possible to handle custom geometries and or specialized simplification with an extended dialect.

This PR is logically related to PR #1285

@stephanr stephanr added the enhancement enhancement or improvement label Mar 11, 2022
@stephanr stephanr added the needs rebase PR is not up to date and needs rebase label Mar 30, 2022
@stephanr stephanr force-pushed the enhancement/extend-sqldialect-oracle-inspector-api branch from 7effe31 to 615db20 Compare April 13, 2022 15:03
@stephanr stephanr removed the needs rebase PR is not up to date and needs rebase label Apr 13, 2022
@stephanr
Copy link
Member Author

The PR was rebased, so it should build now without problems

@stephanr stephanr added the CI failing CI build job fails label Apr 13, 2022
@tfr42 tfr42 added the needs rebase PR is not up to date and needs rebase label May 16, 2022
…loading from database

* refactor internal class POJO to public reachable class SDOGeometry
* fix generating wrong interior size on compound polygon
@stephanr stephanr force-pushed the enhancement/extend-sqldialect-oracle-inspector-api branch from 615db20 to dfe188b Compare September 15, 2022 14:06
@stephanr
Copy link
Member Author

After the problems that appeared after the rebase were solved, the build was successfully.
See https://buildserver.deegree.org/blue/organizations/jenkins/pull-request/detail/PR-1288/39/pipeline/

@stephanr stephanr removed needs rebase PR is not up to date and needs rebase CI failing CI build job fails labels Sep 16, 2022
@copierrj copierrj merged commit 539df93 into deegree:main Nov 2, 2022
@tfr42 tfr42 added this to the 3.5 milestone Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants