Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create spatial index in PostGISDDLCreator #1318

Merged
merged 4 commits into from
May 12, 2022
Merged

Create spatial index in PostGISDDLCreator #1318

merged 4 commits into from
May 12, 2022

Conversation

dstenger
Copy link
Contributor

@dstenger dstenger commented May 5, 2022

This pull request enables creation of a spatial index in PostGISDDLCreator.

@dstenger dstenger added the enhancement enhancement or improvement label May 5, 2022
stempler
stempler reviewed May 6, 2022
View reviewed changes
...eaturestore-sql/src/main/java/org/deegree/feature/persistence/sql/ddl/PostGISDDLCreator.java Outdated

import javax.xml.namespace.QName;

import gcardone.junidecode.Junidecode;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be an unused import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reporting.
I just removed the unused import.

@tfr42 tfr42 added the tests failing unit or Integration tests fail label May 6, 2022
@dstenger
Copy link
Contributor Author

dstenger commented May 6, 2022

Locally, I am able to build the branch with mvn clean install -Pintegration-tests.

mvn --version
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: /opt/maven
Java version: 1.8.0_312, vendor: Private Build, runtime: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "linux", version: "5.13.0-39-generic", arch: "amd64", family: "unix"

@stephanr stephanr merged commit c939e98 into deegree:master May 12, 2022
@tfr42 tfr42 removed the tests failing unit or Integration tests fail label May 12, 2022
@tfr42 tfr42 added this to the 3.4.31 milestone May 13, 2022
@tfr42 tfr42 added WMS deegree Web Map Service tools deegree command line tools (CLI) and removed WMS deegree Web Map Service labels May 13, 2022
@lgoltz lgoltz deleted the createSpatialIdx-390 branch December 8, 2022 09:42
@tfr42 tfr42 mentioned this pull request Dec 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stempler stempler stempler left review comments

Assignees
No one assigned
Labels
enhancement enhancement or improvement tools deegree command line tools (CLI)
Projects
None yet
Milestone
3.4.31
Development

Successfully merging this pull request may close these issues.
5 participants
@dstenger @stempler @tfr42 @stephanr @lgoltz