Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PostGIS 2.5.1, usage of JTS WKTReader instead of PostGIS WKTReader #1367

Merged
merged 4 commits into from
Aug 10, 2022
Merged

Upgrade to PostGIS 2.5.1, usage of JTS WKTReader instead of PostGIS WKTReader #1367

merged 4 commits into from
Aug 10, 2022

Conversation

julianzz98
Copy link
Contributor

Upgrade to PostGIS 2.3.0 to 2.5.1 and switch from PostGIS WKTReader to JTS WKTReader.

julianzz98
julianzz98 commented Jul 27, 2022
View reviewed changes
Copy link
Contributor Author

@julianzz98 julianzz98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for merge-commit @copierrj

@tfr42 tfr42 added this to the 3.5 milestone Jul 27, 2022
@tfr42 tfr42 added the dependencies Pull requests that update a dependency (library) label Jul 27, 2022
tfr42
tfr42 requested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@tfr42 tfr42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal is to move the method createFromJTS() to GeometryUtils as a static method if possible to avoid object creation for converting objects.

@stephanr stephanr merged commit a343e8f into deegree:main Aug 10, 2022
@tfr42 tfr42 added the enhancement enhancement or improvement label Aug 10, 2022
@tfr42 tfr42 mentioned this pull request Sep 17, 2022
Closed
@lgoltz lgoltz deleted the upgradePostGIS-8363-1124 branch December 8, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfr42 tfr42 tfr42 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency (library) enhancement enhancement or improvement
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
4 participants
@julianzz98 @tfr42 @stephanr @lgoltz