Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending the Oracle SQL dialect to allow reading of oriented points #1404

Merged

Conversation

stephanr
Copy link
Member

@stephanr stephanr commented Sep 26, 2022

Processing of OrientedPoints was not implemented before and was realized with this pull request.

This is an revised PR based on #1203 and adds the following:

  • Change from System.getProperty to TunableParameter.get
  • Rebase to clean up commit history (remove unrelated commits)
  • Documentation in the form of an appendix addition

Closes #1203

@stephanr stephanr added enhancement enhancement or improvement WFS deegree Web Feature Service WMS deegree Web Map Service labels Sep 26, 2022
@stephanr stephanr self-assigned this Sep 26, 2022
@stephanr stephanr added this to the 3.5 milestone Sep 26, 2022
@stephanr stephanr added the needs rebase PR is not up to date and needs rebase label Nov 9, 2022
@stephanr stephanr force-pushed the enhancement/correct-oriented-point-dee-194 branch from 0cd59b9 to a4beedb Compare November 11, 2022 15:41
@stephanr stephanr removed the needs rebase PR is not up to date and needs rebase label Nov 14, 2022
@stephanr stephanr force-pushed the enhancement/correct-oriented-point-dee-194 branch from a4beedb to b85112d Compare November 17, 2022 13:10
@stephanr
Copy link
Member Author

The branch was rebased to fix the merge conflict on the appendix. Also the TunableParameter was aligned with the existing parameters (deegree.oracle.export.oriented_point-> deegree.sqldialect.oracle.export_oriented_point).

@copierrj copierrj merged commit b1ba2e8 into deegree:main Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement WFS deegree Web Feature Service WMS deegree Web Map Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants