Reworked profiles section for building deegree-webservices WAR file #1447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…acle to use same dependencies as root pom, and added profile for mssql to add sqldialect to war if enabled.
tfr42
added
enhancement
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused and outdated profiles, adapts existing profile for oracle to use same dependencies as root pom, and adds a profile for mssql to add the sqldialect JAR to WAR file if enabled.
For Oracle and MS SQL Server the JDBC drivers are NOT added to the WEB-INF/lib directory on purpose. Please note the explanations in https://download.deegree.org/documentation/current/html/#anchor-configuration-javamodules. The documentation may contain the following explanation:
The considerations to put JDBC driver JAR files into $CATALINA_HOME/lib directory are that JDBC drivers register themselves in the JVM-wide singleton DriverManager which is shared by all web apps inside of a Tomcat/JVM instance. The class DriverManager gets loaded by the bootstrap classloader and thereby "lives" globally in the JVM, while Tomcat loads all web apps in their own classloaders. So if a JDBC driver from a web app's WEB-INF/lib folder registers itself in DriverManager, it pins that web app's classloader in memory (and thereby all the classes of that web app), preventing its garbage collection when stopped and undeployed.