Fix for dependency conflicts introduced with ehcache 3.x upgrade (PR #1441) #1459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfr42
added
dependencies
This was referenced Jan 23, 2023
Closed
lgoltz
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the broken JAXB dependencies introduced with PR #1441.
The deegree project uses the
jakarta.xml.bind:jakarta.xml.bind-api(API) withcom.sun.xml.bind:jaxb-impl(JAXB implementation).The ehcache project uses
org.glassfish.jaxb:jaxb-runtimein the version range of[2.2,3). This brings duplications of types in different versions from thecom.sun.xml.bindpackage into the classpath and results in build errors.To fix this the
org.glassfish.jaxb:jaxb-runtimedependencies introduced with ehcache are excluded from the dependencies. This shall not affect ehcache at runtime since the difference betweenjaxb-impland thejaxb-runtimeJAR is that thejaxb-implJAR also bundles types fromcom.sun.istackandcom.sun.xml.txw2whereas thejaxb-runtimeprovides them as separate dependencies.More info about JAXB https://github.com/eclipse-ee4j/jaxb-ri/.