Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bbox_cache.properties per SQLFeatureStore #1477

Merged
merged 9 commits into from
May 12, 2023

Conversation

julianzz98
Copy link
Contributor

@julianzz98 julianzz98 commented Mar 8, 2023

This PR replaces the current bbox_cache.properties with bbox_cache_<SQLFeatureStoreId>.properties, therefore enabling the configuration of an individual spatial extend of FeatureTypes with the same name configured in different SQLFeatureStore.

This PR does not solve issue #824!

@julianzz98 julianzz98 added enhancement enhancement or improvement WFS deegree Web Feature Service labels Mar 8, 2023
@julianzz98 julianzz98 self-assigned this Apr 19, 2023
@tfr42
Copy link
Member

tfr42 commented Apr 19, 2023

Add information about the change to the configuration in https://github.com/deegree/deegree3/wiki/Upgrading-deegree-webservices

@julianzz98
Copy link
Contributor Author

According to the TMC, a use case should be added for better understanding of the PR. Furthermore the wiki should be updated regarding breaking changes in deegree 3.5-SNAPSHOT.

@tfr42
Copy link
Member

tfr42 commented May 12, 2023

The current existing behaviour shall be kept. The new behaviour shall be only applied if a file with the proposed name such as bbox_cache_FEATURE_STORE_ID.properties is present.

@copierrj
Copy link
Member

The new behaviour shall be only applied if a file with the proposed name such as bbox_cache_FEATURE_STORE_ID.properties is present.

And perhaps also when no cache exists yet for a feature type present in multiple feature stores?

@lgoltz lgoltz added this to the 3.5 milestone May 12, 2023
@julianzz98
Copy link
Contributor Author

The newly added changes were successfully tested on a local deegree build.

@stephanr stephanr merged commit ef69709 into deegree:main May 12, 2023
@lgoltz lgoltz deleted the bboxCachePerFeatureStore-16-8821 branch August 17, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement WFS deegree Web Feature Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants