Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tests for GMLGeometryValidator handling left- and right-handed CRS (rebase of #1489) #1556

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

stephanr
Copy link
Member

@stephanr stephanr commented Aug 9, 2023

Copied from #1489:

A new test has been created in the GMLGeometryValidatorTest.java.
It tests the orientations of polygons declared with left-handed CRS and right-handed CRS.
We have added 8 different .gml files, considering all possible scenarios:

  • CRS: left-handed, right-handed
  • Exterior ring: clockwise, counterclockwise
  • Interior ring: clockwise, counterclockwise
    Included files are:
  • LeftHanded_exterior_anticlockwise_interior_anticlockwise.gml
  • LeftHanded_exterior_anticlockwise_interior_clockwise.gml
  • LeftHanded_exterior_clockwise_interior_anticlockwise.gml
  • LeftHanded_exterior_clockwise_interior_clockwise.gml
  • RightHanded_exterior_anticlockwise_interior_anticlockwise.gml
  • RightHanded_exterior_anticlockwise_interior_clockwise.gml
  • RightHanded_exterior_clockwise_interior_anticlockwise.gml
  • RightHanded_exterior_clockwise_interior_clockwise.gml

@stephanr stephanr added the enhancement enhancement or improvement label Aug 9, 2023
@stephanr stephanr added this to the 3.5.1 milestone Aug 9, 2023
@tfr42 tfr42 modified the milestones: 3.5.1, 3.5.2 Aug 9, 2023
@tfr42 tfr42 added the tests unit/integration test label Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement tests unit/integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants