Remove Jersey dependency and migrate WPS WSDL functionality to ResourcesServlet #1609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aim was to remove Jersey dependency so that it is not part of deegree-webservices war anymore.
As this dependency was used by WSDL functionality of WPS, this feature was moved to ResourcesServlet.
The servlet now also returns files ending with
.wsdland.wsdl/ALL.wps.wsdl file was created in
servicesfolder of WPS workspace to test the pull request.Example of WSDL URL printed in Capabilities of WPS with the fix:
<wps:WSDL xlink:href="http://localhost:8081/deegree-webservices/resources/services/wps.wsdl/ALL"/>Before is was:
<wps:WSDL xlink:href="http://localhost:8080/deegree-webservices/resources../rest/wsdl/wps/ALL"/>(which seems to be broken)New URL is accessible and returns the added wps.wsdl.
Functionality seems not to be described in the handbook. As the aim of this pull request was to remove Jersey dependency, the handbook was not enhanced.
Finally, I checked if jersey-server dependency is still in WEB-INF/lib folder of deployed war. No jersey dependency was existing anymore.