Parameterize SLF4J's logging statements #1617
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current codebase does not follow the recommendation way of using SLF4J parametrized logging.
This was done, as it is good practice and also boosts performance when the log statement is called often and is not configured to be logged.
With the help of automated rewriting, this was corrected for all cases that could be changed automatically.
The folder
deegree-core/deegree-core-geometry/src/test/java/org/deegree/geometry/linearization
was reviewed and fixed manually, as the automated tool had problems with the test cases.Besides this PR, I would also suggest extending the chapter "Logging" in the wiki (https://github.com/deegree/deegree3/wiki/Developer-Guidelines#logging)
Following good practices, we would like to encourage deegree developers to use parametrized logging whenever possible.
This speeds up logging when the requested level is turned off, for example. It also makes it easier to find messages in the source tree or to filter logging during runtime.
For more details, see https://www.slf4j.org/faq.html#logging_performance