Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression with SVG that would be rendered smaller than one pixel #1632

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

stephanr
Copy link
Member

This PR prevents errors when SVG should be rendered to a size smaller than one pixel.
Probably one of the last batik version updates introduced this issue.

Without this workaround, the following exception occurs:

org.apache.batik.transcoder.TranscoderException: null
Enclosed Exception: 
negative or zero width

Manual tests on existing workspaces showed that even a sub pixel image won't turn into rendering problems as 1×1 images are ignored or rendered correctly scaled (smaller).

References:

* extend test cases to check for error with images requested to be draw smaller than 1px
@stephanr stephanr added bug error issue and bug (fix) WMS deegree Web Map Service labels Jan 11, 2024
@tfr42 tfr42 added this to the 3.6 milestone Jan 24, 2024
@tfr42 tfr42 merged commit a257f6f into deegree:main Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix) WMS deegree Web Map Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants