Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #527 - 3.4: Queryable not configurable #211

Closed

Conversation

diegomigliavacca
Copy link
Contributor

http://tracker.deegree.org/deegree-services/ticket/527

It's possible to set a layer as queryable or not queryable setting the attribute "enabled" on the "l:FeatureInfo" element. This configuration was not working properly.

@diegomigliavacca
Copy link
Contributor Author

I fixed this pull request. It should work now.

If it would not work is because I modified the same files for more than one pull request, so perhaps there are conflicts.

@MrSnyder MrSnyder closed this Apr 24, 2014
@MrSnyder MrSnyder reopened this Apr 24, 2014
@MrSnyder MrSnyder closed this Apr 24, 2014
@MrSnyder MrSnyder reopened this Apr 24, 2014
@MrSnyder
Copy link
Contributor

Thanks for your contribution! Unfortunately, it does not compile / has test errors. It cannot be considered for inclusion, before this has been fixed. Sorry.

Additional information:

NOTE: Recently, there have been important changes to the integration tests. Before running them, please merge the current master into your branch.

@tfr42 tfr42 added this to the 3.4 milestone May 7, 2014
@tfr42
Copy link
Member

tfr42 commented Jul 2, 2014

Your pull request has been discussed by the TMC (http://wiki.deegree.org/deegreeWiki/TmcMeeting/TmcMeeting20140606). Please see the following remarks from the TMC members:

  • We are waiting for your feedback if you have been able to merge the current master into your branch.

However, we found that it is not ready yet for inclusion:
The TMC would be happy if you can find the time to address these shortcomings.

@tfr42 tfr42 added bug labels Jul 10, 2014
@diegomigliavacca
Copy link
Contributor Author

Now it compiles. But there are "deegree-compliance-tests" errors.

@tfr42
Copy link
Member

tfr42 commented Jul 24, 2014

Can you please post the error messages here.

@tfr42 tfr42 added the contributions welcome asking for contribution (time and money sponsor) label Mar 4, 2015
@stephanr
Copy link
Member

I think this one should be superseded by #519 which fixed the issue on a wider scope.

@MrSnyder MrSnyder added the stuck stuck PR label Apr 24, 2015
@tfr42 tfr42 assigned tfr42 and unassigned diegomigliavacca Apr 24, 2015
@diegomigliavacca
Copy link
Contributor Author

yes, the first part of the PR #519 fixes this issue as well.
I can close this pull request.

@diegomigliavacca diegomigliavacca deleted the bug#527-3.4 branch April 24, 2015 16:21
@tfr42 tfr42 removed this from the 3.4 milestone Oct 1, 2015
@tfr42 tfr42 added invalid invalid and removed bug error issue and bug (fix) contributions welcome asking for contribution (time and money sponsor) needs discussion requires discussion with contributor labels Oct 1, 2015
@tfr42 tfr42 removed stuck stuck PR tests failing unit or Integration tests fail labels Oct 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants