GetFeatureInfo improvements #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into FeatureInfoContext
implementing FeatureInfoSerializer
lgoltz
added a commit
to lat-lon/deegree3
that referenced
this pull request
Nov 1, 2016
…ase layer config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains GetFeatureInfo improvements:
It introduces a new concept called FeatureInfoContext to separate the stateless GetFeatureInfo parameters from the stateful stuff (e.g. XMLWriter, OutputStream etc.). This resolves a rather remarkable bug that resulted in an xml header being written at the bottom of xslt output. It also creates a convenient abstraction to add new functionality.
In order to be able to fully customize the GetFeatureInfo it is now possible to point to a custom FeatureInfoSerializer implementation in the WMS configuration.
To glue the GetFeatureInfo request to complementary html generating software, a sendRedirect method is made available to the FeatureInfoSerialize to simply redirect the client to another url.