-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OGC GeoPackage implementation - 3.4 #333
Conversation
With the OracleJDK, the build succeeded. WARN: The method class org.apache.commons.logging.impl.SLF4JLogFactory#release() was invoked. No output has been received in the last 10 minutes, this potentially indicates a stalled build or something wrong with the build itself. The build has been terminated |
94c2a06
to
4ad3f0a
Compare
2542775
to
59a28b3
Compare
3670fc7
to
118f49e
Compare
I tested this Geopackage implementation and it works properly. Besides, on my Pc, with the Oracle JDK, there aren't test failures during the build process using "mvn clean install -Pintegration-tests". I suggest to test it again on some other computer, maybe with OpenJDK too. Then, I think it will be possible to integrate it in Deegree. |
TravisCI failed as some artifacts could not be fetched: [ERROR] Failed to execute goal on project deegree-core-commons: Could not resolve dependencies for project org.deegree:deegree-core-commons:jar:3.4-pre16-SNAPSHOT: The following artifacts could not be resolved: jogl:jogl:jar:1.1.2, org.deegree:deegree-ogcschemas:jar:20120804: Could not find artifact jogl:jogl:jar:1.1.2 in central (http://repo.maven.apache.org/maven2) -> [Help 1] |
Thank you for your contribution. Unfortunately, it cannot be merged automatically. It cannot be considered for inclusion, before this has been fixed. Please rebase it against the target branch. |
118f49e
to
9f98d3c
Compare
08ce095
to
7194218
Compare
I did it. Now my branch is up to date. |
Thank you for your contribution. Your pull request has been discussed by the TMC today. Please see the following remarks from the TMC members:
However, we found that it is not ready yet for inclusion: |
I think it's a really good idea to move it to a later stable release version of 3.4. |
Dear deegree users! If someone of you would like this PR merged and want this as an official part of deegree, then please act now. Either rebase and fix the build or post a comment. Otherwise we will close this PR soon. |
TMC consider this PR as very interesting and would like to continue. Volunteers are very welcome! Please get in contact with the TMC. |
@@ -92,6 +92,7 @@ public void startup( Workspace workspace ) { | |||
try { | |||
for ( Driver d : ServiceLoader.load( Driver.class, workspace.getModuleClassLoader() ) ) { | |||
registerDriver( new DriverWrapper( d ) ); | |||
registerDriver( new DriverWrapper( new org.sqlite.JDBC() ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if instantiating the driver manually is a good idea.
@diegomigliavacca Thank you for updating this pull request! Unfortunately Travis CI was not able to build and test your branch. |
Hi!! Yes, removing that registerDriver was the main task. For the rest, you only have to upgrade the Deegree version in the pom.xml files and update the dependencies in the geopackage pom files. Then, it will work. |
Based on @diegomigliavacca work a new PR #1437 has been created to support target version 3.5 |
The TMC decided to close this PR in favor of #1437 |
http://tracker.deegree.org/deegree-services/ticket/613
"The GeoPackage specification describes an open, standards-based, platform-independent, portable, self-describing, compact format for transferring geospatial information. It is a set of conventions for SQLite to store interoperable Features and/or Tiles on a common base" (opengis/geopackage GitHub repository).
For the feature part, the user needs to configure in Deegree:
an SQL feature store;
a WFS service;
a JDBC connection;
a Feature Layer.
For the tile part, the user needs to configure:
a WMTS service;
a Gpkg Tile Store;
a Tile Layer.
Configuration of a JDBC connection (example):
User and Password can just to be set to "null", given that GeoPackage is based on SQLite.
Configuration of a Gpkg Tile Store (example):