Removed catch (Throwable) in OracleSqlDialect to improve error handling and logging #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstenger
changed the title
tfr42
added
enhancement
|
Tests still failing. Restarted. |
|
The TMC discussed that it would be better to keep logic of createing a new IllegalArgumentException instead of letting the orignal Exception pass. To achive this, i prepared a pull request at #545 which reflects these changes. |
tfr42
added
invalid
|
PR #545 is replaces this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught throwables were removed (and throw of new IllegalArgumentExceptions without message) to improve the exception handling (now, the "original" exception is thrown instead of a new IllegalArgumentException).
In addition, the logging will be more detailed as log messages can now contain the "original" exception instead of the new IllegalArgumentException.