Bugfix/restore build information via ModuleInfo #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed ModuleInfo to read from mafifest.mf instead of buildinfo.properties - removed deegree-maven-plugin:generate-buildinfo from build
…ars like deegree-ogcschemas-*
|
The deegree 3.3 line is not affected (the generation of buildinfo.properties is still active there). |
MrSnyder
added a commit
that referenced
this pull request
Nov 11, 2014
Bugfix/restore build information via ModuleInfo
|
Thank you for your contribution. Your pull requests has been accepted by the TMC. Please find more information in the meeting chat available at http://wiki.deegree.org/deegreeWiki/TmcMeeting/TmcMeeting20141111. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current build information logic is deactivates, as the deegree-maven-plugin is only available via separate profile flag, so no ModuleInformation about the loaded Modules (jar) are currently available at startup / in console.
This pull restores the logic without using an external plugin (to reduce complexity and extra files). It uses the already available manifest.mf generation process of maven and extends it to include deegree-* key/value pairs to include the build information.