-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SVG support to WMS #469
Conversation
Short statement to add about the performance impact, in which scenario does this occur and how can this made configurable. |
this speeds up rendering if paintImage is called before any other drawing
Regarding the performance issue: Currently the GDAL layer replaces the image used by the render context (as render target) instead of painting the GDAL images on top of the existing image. This results in a performance increase. This behavior results in the wrong image when multiple layers are requested (what usually isn't happening when using GDAL). In the SVG render context we cannot use this approach as we do not have an image as render target. Therefore I removed this performance 'hack' during implementation of the SVG support. Possible solution: a lazy image render context that doesn't allocate an image until one is needed. See: IDgis/deegree3@469318e |
to ensure that image formats in the WMS capabilities are in a fixed order
I've tested the previously mention 'lazy image render context' approach with the GDAL layer and after some tweaking concluded that the resulting behavior is as expected: when only a single GDAL layer is rendered, the image obtained from GDAL is returned to the client without any additional processing. |
Thank you for your contribution. Your pull requests has been accepted by the TMC today. |
This pull adds support for SVG to the WMS. Based on a proof of concept implementation by @erikorbons.
It required a change in the GDAL layer implementation that might hurt performance in some cases.