Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG support to WMS #469

Merged
merged 8 commits into from
Feb 6, 2015
Merged

Conversation

copierrj
Copy link
Member

This pull adds support for SVG to the WMS. Based on a proof of concept implementation by @erikorbons.

It required a change in the GDAL layer implementation that might hurt performance in some cases.

@copierrj copierrj added in progress enhancement enhancement or improvement labels Jan 10, 2015
@tfr42 tfr42 added this to the 3.4 milestone Jan 10, 2015
@tfr42 tfr42 changed the title SVG support Add SVG support Jan 10, 2015
@tfr42 tfr42 added the needs discussion requires discussion with contributor label Jan 10, 2015
@tfr42
Copy link
Member

tfr42 commented Jan 10, 2015

Short statement to add about the performance impact, in which scenario does this occur and how can this made configurable.

@tfr42 tfr42 changed the title Add SVG support Add SVG support for WMS with GDAL tile store Jan 10, 2015
this speeds up rendering if paintImage is called before any other
drawing
@copierrj
Copy link
Member Author

Regarding the performance issue:

Currently the GDAL layer replaces the image used by the render context (as render target) instead of painting the GDAL images on top of the existing image. This results in a performance increase.

This behavior results in the wrong image when multiple layers are requested (what usually isn't happening when using GDAL).

In the SVG render context we cannot use this approach as we do not have an image as render target. Therefore I removed this performance 'hack' during implementation of the SVG support.

Possible solution: a lazy image render context that doesn't allocate an image until one is needed. See: IDgis/deegree3@469318e

@copierrj copierrj changed the title Add SVG support for WMS with GDAL tile store Add SVG support for WMS (with GDAL layer issue) Jan 10, 2015
to ensure that image formats in the WMS capabilities are in a fixed
order
@copierrj copierrj changed the title Add SVG support for WMS (with GDAL layer issue) Add SVG support for WMS Jan 12, 2015
@copierrj
Copy link
Member Author

I've tested the previously mention 'lazy image render context' approach with the GDAL layer and after some tweaking concluded that the resulting behavior is as expected: when only a single GDAL layer is rendered, the image obtained from GDAL is returned to the client without any additional processing.

@copierrj copierrj changed the title Add SVG support for WMS Add SVG support to WMS Jan 12, 2015
@copierrj copierrj mentioned this pull request Feb 6, 2015
@tfr42 tfr42 removed the needs discussion requires discussion with contributor label Feb 6, 2015
@tfr42
Copy link
Member

tfr42 commented Feb 6, 2015

Thank you for your contribution. Your pull requests has been accepted by the TMC today.
This pull request will be part of the 3.4-pre17 release.

MrSnyder added a commit that referenced this pull request Feb 6, 2015
@MrSnyder MrSnyder merged commit ce48392 into deegree:master Feb 6, 2015
@copierrj copierrj mentioned this pull request Feb 7, 2015
@tfr42 tfr42 added feature feature and removed enhancement enhancement or improvement labels Mar 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants