Enhances WMS to throw an exception if the requested CRS is not configured #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is OK. But for the RC line we accept bug fixes only. This is why we have put it onto milestone 3.5. It might be included in 3.4.1 too. |
tfr42
added
needs rebase
…tionIfCrsIsNotConfigured-163
|
The TMC discussed this pull request which resulted in a more in depth discussion related to the proposed xml schema change. We decided to not yet merge this PR and continue the discussion in the next TMC meeting. See for details: #953 |
…sIsNotConfigured-163
…sIsNotConfigured-163
tfr42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the WMS throws an exception if the requested CRS in GetMap and GetFeature requests is not supported by deegree. This pull requests changes this behavior to throw an InvalidSRS/InvalidCRS exception if the requested CRS is not configured (not declared in the capabilities).
To avoid breaking of clients expecting the old behavior this is configurable. By default deegree checks only if the CRS is not supported. To limit this to the configured CRS, the service configuration must be extended: