[WIP]Fixed bug in SqlFeatureStore if configuration is stored in subfolders #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted in a subfolder.
|
Review postponed to next TMC meeting. |
|
I am currently in the process of reviewing this pull request. |
stephanr
changed the title
|
I close this PR, because it has been waiting for a long time and there are no planned resources for it at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the configuration of the feature ist stored in a subfolder of the features folder, this subfolder was added twice to the file-url.
Example:
Configuration is stored in //path/to/datasources/feature/subfolder/config.xml
resolveToFile combines "//path/to/datasources/feature/subfolder/" and "subfolder/config" + ".xml"
With this Fix, only the filename ("config") is taken from the identifier to get the right filepath.