-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQLFeatureStore: Fix filtering on gml:identifier in BLOB mode #682
SQLFeatureStore: Fix filtering on gml:identifier in BLOB mode #682
Conversation
71ba6b3
to
074d673
Compare
The TMC reviewed this PR and decided that in order to consider it for merging it should be rebased first. Although not technically required by git, we would like this PR to be rebuild / retested by travis using the pom.xml and travis configuration currently in master. |
Reminder to TMC: infrastructure changes as outlined in #851 should be finalized before merging this issue. Otherwise we might not be able to do release builds anymore! |
Thank you for your contribution. Unfortunately, the TMC members came to the conclusion not to merge it into the deegree code base since the PR get stuck (see PR marked for deletion). Of course this is not the final word. If you think, that we did wrong then please re-initiate the Decision Making Process by making a opening an updated pull request and taking the feedback from the TMC into consideration. Perhaps we can then merge that new pull request. Anyhow, we do appreciate your commitment to open source and to deegree in special. |
Before this patch, queries that filter based on the gml:identifier property would not match any features. The patches fixes that so the expected feature is returned. Test case included.
Depends on #665.