Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLFeatureStore: Fix filtering on gml:identifier in BLOB mode #682

Conversation

MrSnyder
Copy link
Contributor

Before this patch, queries that filter based on the gml:identifier property would not match any features. The patches fixes that so the expected feature is returned. Test case included.

Depends on #665.

@MrSnyder MrSnyder added the bug error issue and bug (fix) label Feb 27, 2016
@MrSnyder MrSnyder self-assigned this Feb 27, 2016
@MrSnyder MrSnyder added this to the 3.4 milestone Feb 27, 2016
@MrSnyder MrSnyder force-pushed the bugfix/featurestore-sql/blob-mode-gml-identifier-filter branch from 71ba6b3 to 074d673 Compare February 28, 2016 10:54
@tfr42 tfr42 added the under review PR under review by TMC member label Aug 17, 2016
@tfr42 tfr42 added contributions welcome asking for contribution (time and money sponsor) stuck stuck PR labels Sep 15, 2016
@tfr42 tfr42 added needs rebase PR is not up to date and needs rebase and removed in progress labels Dec 1, 2017
@copierrj
Copy link
Member

copierrj commented Dec 1, 2017

The TMC reviewed this PR and decided that in order to consider it for merging it should be rebased first. Although not technically required by git, we would like this PR to be rebuild / retested by travis using the pom.xml and travis configuration currently in master.

@copierrj
Copy link
Member

copierrj commented Dec 1, 2017

Reminder to TMC: infrastructure changes as outlined in #851 should be finalized before merging this issue. Otherwise we might not be able to do release builds anymore!

@vog
Copy link
Contributor

vog commented Dec 5, 2017

This pull request depends on #665, so it makes no sense to rebase it before #665 is resolved.

@tfr42 tfr42 modified the milestones: 3.4, 3.4.1 Apr 6, 2018
@tfr42 tfr42 modified the milestones: 3.4.1, 3.5 Jun 18, 2018
@tfr42
Copy link
Member

tfr42 commented Jun 14, 2019

Thank you for your contribution. Unfortunately, the TMC members came to the conclusion not to merge it into the deegree code base since the PR get stuck (see PR marked for deletion). Of course this is not the final word. If you think, that we did wrong then please re-initiate the Decision Making Process by making a opening an updated pull request and taking the feedback from the TMC into consideration. Perhaps we can then merge that new pull request. Anyhow, we do appreciate your commitment to open source and to deegree in special.

@tfr42 tfr42 closed this Jun 14, 2019
@tfr42 tfr42 modified the milestones: 3.5, Backlog Jun 14, 2019
@tfr42 tfr42 removed the under review PR under review by TMC member label May 15, 2022
@tfr42 tfr42 removed this from the Backlog milestone Nov 30, 2023
@tfr42 tfr42 added marked for deletion PR with that label will be closed soon and removed needs rebase PR is not up to date and needs rebase contributions welcome asking for contribution (time and money sponsor) labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix) marked for deletion PR with that label will be closed soon stuck stuck PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants