Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.4 Bugfix: prevent control characters in content-type that break the transfer encoding #689

Conversation

stephanr
Copy link
Member

Currently the WFS service sends the configured mime-type as content type to the client as it got read from the configuration.

Under Weblogic this reults to a problem if the configuration is formated like the following example:

  <GMLFormat gmlVersion="GML_2">
    <MimeType>
      <![CDATA[text/xml; subtype="gml/2.1.2"]]>
    </MimeType>
    <MimeType>
      <![CDATA[text/xml; subtype=gml/2.1.2]]>
    </MimeType>
    <GetFeatureResponse>
      <DisableStreaming>true</DisableStreaming>
    </GetFeatureResponse>
  </GMLFormat>

This configuration fragment introduced additional white-space/control characters before or after the content-type so that a java/httpclient software faild to handle the transfer encoding of the result of deegree.

The effect could be fixed by removing the xml formatting, which is not a good solution as it could break any moment if someone formats the document:

  <GMLFormat gmlVersion="GML_2">
    <MimeType><![CDATA[text/xml; subtype="gml/2.1.2"]]></MimeType>
    <MimeType><![CDATA[text/xml; subtype=gml/2.1.2]]></MimeType>
    <GetFeatureResponse>
      <DisableStreaming>true</DisableStreaming>
    </GetFeatureResponse>
  </GMLFormat>

… white-space characters from content-type/mime-type
@stephanr stephanr self-assigned this Apr 12, 2016
@stephanr stephanr added the bug error issue and bug (fix) label Apr 12, 2016
@stephanr stephanr added this to the 3.4 milestone Apr 12, 2016
@copierrj copierrj merged commit e976e5f into deegree:master Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants