Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate crs and valid domain during transactions #692

Conversation

dstenger
Copy link
Contributor

@dstenger dstenger commented May 2, 2016

Chapter A.2.18.2 of the WFS 2.0.0 states following:

...
(1.) Insert another feature with geometries where the value of the srsName parameter is not one of the SRS values the server claims to support in its capabilities document. Verify that the server responds with an exception.
(2.) Insert a final feature with geometries where the value of the srsName is one of the SRS values the server claims to support in its capabilities but the geometries in the insert action are encoded with an SRS that does not match the one asserted as the value of the srsName parameter. Verify that the server responds with an exception.

This enhancement enables those two behaviours for insert transactions:

  1. A check is implemented if any srsName parameter value of the request is present in the capabilities document. If this is not the case, an exception is thrown.
  2. A check is added if any used geometries are outside the valid domain of the corresponding SRS. If this is not the case, an exception is thrown.

@dstenger dstenger added enhancement enhancement or improvement in progress labels May 2, 2016
@tfr42 tfr42 added this to the 3.4 milestone Jun 10, 2016
@tfr42 tfr42 modified the milestones: 3.4.1, 3.4 Aug 9, 2016
@tfr42 tfr42 added the CI failing CI build job fails label Aug 11, 2016
@dstenger dstenger added needs rebase PR is not up to date and needs rebase and removed CI failing CI build job fails labels Nov 16, 2017
@dstenger dstenger removed the needs rebase PR is not up to date and needs rebase label Nov 16, 2017
@tfr42 tfr42 modified the milestones: 3.4.1, 3.5 Jun 18, 2018
@tfr42 tfr42 modified the milestones: 3.5, 3.4.3 Jul 20, 2018
@tfr42 tfr42 modified the milestones: 3.4.3, 3.4.4 Sep 28, 2018
@copierrj
Copy link
Member

copierrj commented Nov 9, 2018

This pull request looks like it is still work in progress. Any update to report?

@tfr42
Copy link
Member

tfr42 commented Dec 14, 2018

It will checked against OGC TEAM engine with WFS 2.0 ETS against http://cite.deegree.org/deegree-webservices-3.4.0/

@copierrj copierrj merged commit 7775fe0 into deegree:master Dec 14, 2018
@lgoltz lgoltz deleted the validateCrsAndValidDomainDuringTransactions-375 branch December 8, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants